Fixed an issue in JSON-RPC event stream services (none exist yet) where retries excluded the initial-request event. #2673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re retries excluded the initial-request event. Before this change, the AsyncStreamPrepender (a Publisher) does not support multiple subscribe calls, but each attempt makes a new subscribe call. Because of this, if a retry is encountered, backpressure is miscalculated and the initial-request is not sent for the retries.
|
Kudos, SonarCloud Quality Gate passed! |
dagnir
approved these changes
Aug 24, 2021
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Aug 25, 2023
Revert "Modify ArnResource to handle more variants of resources (#4317)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the AsyncStreamPrepender (a Publisher) does not support multiple subscribe calls, but each attempt makes a new subscribe call. Because of this, if a retry is encountered, backpressure is miscalculated and the initial-request
is not sent for the retries.